Severity
Details
- CVSS vector
- CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:X
Overview
About vulnerability
The SPDY/3 frame parser in spdystream does not validate attacker-controlled counts and lengths before allocating memory. A remote peer that can send SPDY frames to a service using spdystream can cause the process to allocate gigabytes of memory with a small number of malformed control frames, leading to an out-of-memory crash.
Three allocation paths in the receive side are affected:
-
SETTINGS entry count – The SETTINGS frame reader reads a 32-bit
numSettingsfrom the payload and allocates a slice of that size without checking it against the declared frame length. An attacker can setnumSettingsto a value far exceeding the actual payload, triggering a large allocation before any setting data is read. -
Header count –
parseHeaderValueBlockreads a 32-bitnumHeadersfrom the decompressed header block and allocates anhttp.Headermap of that size with no upper bound. -
Header field size – Individual header name and value lengths are read as 32-bit integers and used directly as allocation sizes with no validation.
Because SPDY header blocks are zlib-compressed, a small on-the-wire payload can decompress into attacker-controlled bytes that the parser interprets as 32-bit counts and lengths. A single crafted frame is enough to exhaust process memory.
Impact
Any program that accepts SPDY connections using spdystream – directly or through a dependent library – is affected. A remote peer that can send SPDY frames to the service can crash the process with a single crafted SPDY control frame, causing denial of service.
Affected versions
github.com/moby/spdystream <= v0.5.0
Fix
v0.5.1 addresses the receive-side allocation bugs and adds related hardening:
Core fixes:
-
SETTINGS entry-count validation – The SETTINGS frame reader now checks that
numSettingsis consistent with the declared frame length (numSettings <= (length-4)/8) before allocating. -
Header count limit –
parseHeaderValueBlockenforces a maximum number of headers per frame (default: 1000). -
Header field size limit – Individual header name and value lengths are checked against a per-field size limit (default: 1 MiB) before allocation.
-
Connection closure on protocol error – The connection read loop now closes the underlying
net.Connwhen it encounters anInvalidControlFrameerror, preventing further exploitation on the same connection.
Additional hardening:
- Write-side bounds checks – All frame write methods now verify that payloads fit within the 24-bit length field, preventing the library from producing invalid frames.
Configurable limits:
- Callers can adjust the defaults using
NewConnectionWithOptionsor the lower-levelspdy.NewFramerWithOptionswith functional options:WithMaxControlFramePayloadSize,WithMaxHeaderFieldSize, andWithMaxHeaderCount.
Details
- Affected product:
- Grafana , Loki , argocd , argoproj/gitops-engine , grafana/e2e , grafana/grafana-app-sdk , grafana/grafana/apps/playlist , grafana/tempo , hashicorp/consul , hashicorp/go-discover , influxdata/telegraf , kubernetes/api , kubernetes/apiextensions-apiserver , kubernetes/apimachinery , kubernetes/apiserver , kubernetes/client-go , kubernetes/component-base , kubernetes/kube-aggregator , kubernetes/kubectl , kubernetes/kubernetes , moby/spdystream , prometheus/prometheus
- Affected packages:
- github.com/moby/spdystream @ 0.2.0 (+61 more)